Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

JS: Toctree expand links #1279

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nienn
Copy link
Contributor

@nienn nienn commented Jan 17, 2022

This narrows the JS selector scope that is currently targeting possible unwanted elements.

@nienn nienn changed the title Toctree: Narrow JS targeting for adding the expand links Toctree JS: Expand links Jan 17, 2022
@nienn nienn changed the title Toctree JS: Expand links JS: Toctree expand links Jan 17, 2022
@nienn
Copy link
Contributor Author

nienn commented Jan 17, 2022

@nienn nienn marked this pull request as ready for review January 24, 2022 16:56
@nienn nienn requested a review from a team as a code owner January 24, 2022 16:56
@MuellerSeb
Copy link

What's the status on this?

@samuel-emrys
Copy link

I'd like to see this merged in - it's an annoying idiosyncrasy to be aware of when adding to the extended menu. @agjohnson @benjaoming are either of you able to advise on the state of this?

@benjaoming benjaoming added this to the 2.0 milestone Feb 15, 2023
@benjaoming
Copy link
Contributor

@samuel-emrys

the culprit is probably that this small PR wasn't added to a milestone, I've added it to the 2.0 milestone since that's the upcoming milestone currently.

I don't see any potential of complexity here, it's very easy to verify and already verified by several people that this works.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links in extended menu layout get unneeded button with sphinx_rtd_theme v1
4 participants